Skip to content

Conversation

@gargsaumya
Copy link
Contributor

@gargsaumya gargsaumya commented Dec 15, 2025

Work Item / Issue Reference

AB#40703

GitHub Issue: #<ISSUE_NUMBER>


Summary

This pull request primarily refactors the Azure DevOps pipeline for GitHub synchronization and makes minor code style improvements across the C++ and Python codebases. The pipeline changes simplify the sync process and improve conflict handling, while the codebase changes mostly involve formatting for better readability and maintainability.

Azure DevOps Pipeline Improvements:

  • Simplified the sync process by checking out the repository directly (checkout: self) and removing redundant clone and remote-add steps. The pipeline now adds the GitHub remote and fetches the main branch in a single step.
  • Improved branch creation and sync logic: now creates the sync branch directly from the current state and pulls from GitHub main, handling merge conflicts by always accepting the GitHub version as the source of truth.
  • Changed the push target from the previous Azure DevOps remote to the default origin remote, aligning with the new checkout approach.
  • Cleaned up unnecessary workingDirectory specifications after refactoring the pipeline steps.

C++ Code Formatting and Readability:

  • Reformatted function calls and object constructions in connection.cpp and connection_pool.cpp to improve readability, especially for multi-argument lines. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
  • Minor code cleanup in ddbc_bindings.cpp, including duplicate attribute resets in FetchAll_wrap (possibly unintentional). [1] [2]

Python Code Formatting:

  • Reformatted long lines in test files and utility code for better readability, especially in SQL statements and exception handling. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Removed an unnecessary blank line in type.py.

These changes collectively improve CI/CD reliability and code maintainability.

Copilot AI review requested due to automatic review settings December 15, 2025 15:34
@github-actions github-actions bot added the pr-size: small Minimal code update label Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

📊 Code Coverage Report

🔥 Diff Coverage

100%


🎯 Overall Coverage

74%


📈 Total Lines Covered: 5259 out of 7023
📁 Project: mssql-python


Diff Coverage

Diff: main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.


📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)
mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.cpp: 66.2%
mssql_python.row.py: 66.2%
mssql_python.helpers.py: 67.5%
mssql_python.pybind.connection.connection.cpp: 73.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.connection.py: 83.5%
mssql_python.cursor.py: 84.3%
mssql_python.__init__.py: 84.9%

🔗 Quick Links

⚙️ Build Summary 📋 Coverage Details

View Azure DevOps Build

Browse Full Coverage Report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Collaborator

@bewithgaurav bewithgaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great PR!

@gargsaumya gargsaumya merged commit 264b825 into main Dec 16, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-size: small Minimal code update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants