Fix | Fix SQLServerConnection.abort() API behavior to clear resources consistently#983
Merged
cheenamalhotra merged 4 commits intomicrosoft:devfrom Mar 13, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #983 +/- ##
===========================================
- Coverage 50.61% 50.6% -0.02%
+ Complexity 2921 2920 -1
===========================================
Files 120 120
Lines 27996 27995 -1
Branches 4681 4677 -4
===========================================
- Hits 14170 14166 -4
- Misses 11530 11535 +5
+ Partials 2296 2294 -2
Continue to review full report at Codecov.
|
peterbae
previously approved these changes
Mar 12, 2019
ulvii
approved these changes
Mar 13, 2019
rene-ye
approved these changes
Mar 13, 2019
lilgreenbird
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per Java Specifications, executing
Connection.abort(Executor executor), must also release all resources and mark the connection closed asConnection.close()would.The PR fixes the same by managing resource cleanup separately in a common internal method.