Skip to content

Fix | ThreadPoolExecutor thread preventing JVM from exiting#944

Merged
rene-ye merged 1 commit intomicrosoft:devfrom
rene-ye:timeoutDaemonFix
Jan 25, 2019
Merged

Fix | ThreadPoolExecutor thread preventing JVM from exiting#944
rene-ye merged 1 commit intomicrosoft:devfrom
rene-ye:timeoutDaemonFix

Conversation

@rene-ye
Copy link
Copy Markdown
Member

@rene-ye rene-ye commented Jan 25, 2019

Changed a thread used to initialize ScheduledThreadPoolExecutor to daemon so the JVM can exit in specific bulkcopy scenarios.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 25, 2019 •
edited
Loading

Codecov Report

Merging #944 into dev will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #944      +/-   ##
============================================
- Coverage     50.55%   50.53%   -0.02%     
+ Complexity     2918     2916       -2     
============================================
  Files           120      120              
  Lines         27984    27987       +3     
  Branches       4678     4678              
============================================
- Hits          14146    14143       -3     
- Misses        11546    11551       +5     
- Partials       2292     2293       +1
Flag Coverage Δ Complexity Δ
#JDBC42 50.13% <100%> (+0.02%) 2880 <1> (+2) ⬆️
#JDBC43 50.45% <100%> (-0.06%) 2909 <1> (-6)
Impacted Files Coverage Δ Complexity Δ
...java/com/microsoft/sqlserver/jdbc/SharedTimer.java 82.14% <100%> (+2.14%) 10 <1> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.36% <0%> (-1.3%) 42% <0%> (-3%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-1.1%) 15% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.85% <0%> (-0.44%) 89% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.47% <0%> (-0.12%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.56% <0%> (+0.07%) 315% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.92% <0%> (+0.19%) 6% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (+0.43%) 112% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d11613...859ea60. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.2.0 milestone Jan 25, 2019
@rene-ye rene-ye merged commit 0702af9 into microsoft:dev Jan 25, 2019
@rene-ye rene-ye deleted the timeoutDaemonFix branch January 25, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+2 more reviewers

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rene-ye @codecov-io @cheenamalhotra @ulvii @peterbae @lilgreenbird