Skip to content

Fix | Thai locale bug in JUnit tests#941

Merged
rene-ye merged 5 commits intomicrosoft:devfrom
rene-ye:thaiLocalBug
Jan 24, 2019
Merged

Fix | Thai locale bug in JUnit tests#941
rene-ye merged 5 commits intomicrosoft:devfrom
rene-ye:thaiLocalBug

Conversation

@rene-ye
Copy link
Copy Markdown
Member

@rene-ye rene-ye commented Jan 23, 2019

No description provided.

@rene-ye rene-ye changed the title Fix | Thai local bug in JUnit tests Fix | Thai locale bug in JUnit tests Jan 23, 2019
cheenamalhotra
cheenamalhotra previously approved these changes Jan 23, 2019
View reviewed changes
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 23, 2019 •
edited
Loading

Codecov Report

Merging #941 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #941      +/-   ##
============================================
- Coverage     50.52%   50.51%   -0.02%     
+ Complexity     2920     2915       -5     
============================================
  Files           120      120              
  Lines         27984    27984              
  Branches       4678     4678              
============================================
- Hits          14140    14136       -4     
- Misses        11553    11557       +4     
  Partials       2291     2291
Flag Coverage Δ Complexity Δ
#JDBC42 50.02% <ø> (-0.09%) 2870 <ø> (-11)
#JDBC43 50.47% <ø> (+0.05%) 2913 <ø> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-1.1%) 15% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.37% <0%> (-0.5%) 313% <0%> (-6%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.85% <0%> (-0.44%) 89% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.41% <0%> (-0.06%) 0% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.58% <0%> (+0.06%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.63% <0%> (+0.12%) 254% <0%> (+1%) ⬆️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 53.41% <0%> (+0.19%) 216% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.57% <0%> (+0.21%) 43% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (+0.43%) 111% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 67.13% <0%> (+0.6%) 64% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3734fd2...bcc8e03. Read the comment docs.

@rene-ye rene-ye merged commit 1d11613 into microsoft:dev Jan 24, 2019
@cheenamalhotra cheenamalhotra added this to the 7.2.0 milestone Jan 30, 2019
@rene-ye rene-ye deleted the thaiLocalBug branch October 10, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+2 more reviewers

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rene-ye @codecov-io @cheenamalhotra @ulvii @peterbae @lilgreenbird