Skip to content

Fix/improve StringBuilder usages#861

Merged
cheenamalhotra merged 2 commits intomicrosoft:devfrom
simon04:fix-stringbuilder-usage
Oct 30, 2018
Merged

Fix/improve StringBuilder usages#861
cheenamalhotra merged 2 commits intomicrosoft:devfrom
simon04:fix-stringbuilder-usage

Conversation

@simon04
Copy link
Copy Markdown
Contributor

@simon04 simon04 commented Oct 26, 2018

  • Replace string concatenation w/ StringBuilder in loops
  • Avoid string concatenation in StringBuilder.append()

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 26, 2018 •
edited
Loading

Codecov Report

Merging #861 into dev will increase coverage by 0.05%.
The diff coverage is 44.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #861      +/-   ##
============================================
+ Coverage     48.67%   48.73%   +0.05%     
- Complexity     2793     2796       +3     
============================================
  Files           116      116              
  Lines         27875    27877       +2     
  Branches       4650     4650              
============================================
+ Hits          13569    13585      +16     
+ Misses        12099    12087      -12     
+ Partials       2207     2205       -2
Flag Coverage Δ Complexity Δ
#JDBC42 48.23% <44.82%> (+0.07%) 2754 <0> (+6) ⬆️
#JDBC43 48.64% <44.82%> (+0.07%) 2795 <0> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 24.56% <0%> (-0.06%) 31 <0> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.57% <0%> (+0.05%) 135 <0> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.42% <0%> (+0.43%) 90 <0> (+1) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.44% <100%> (ø) 31 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.73% <100%> (-0.07%) 263 <0> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 56.5% <100%> (+0.34%) 0 <0> (ø) ⬇️
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 34.84% <80%> (-0.08%) 66 <0> (ø)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.94% <0%> (-1.48%) 11% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.57% <0%> (-0.12%) 255% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f097cd...c552781. Read the comment docs.

@rene-ye
Copy link
Copy Markdown
Member

rene-ye commented Oct 27, 2018

Please format the code with mssql-jdbc_formatter.xml found in the root of the repository.

@simon04 simon04 force-pushed the fix-stringbuilder-usage branch from e617d0e to c552781 Compare October 27, 2018 06:41
@simon04
Copy link
Copy Markdown
Contributor Author

simon04 commented Oct 27, 2018

Thanks for the pointer. I amended my commits. Hopefully, I didn't forget something.

@cheenamalhotra cheenamalhotra merged commit 001b413 into microsoft:dev Oct 30, 2018
ulvii pushed a commit that referenced this pull request Nov 30, 2018
@simon04 @ulvii
Improvement | Replace string concatenation with StringBuilder (#861)
d7a7ce2 
* Avoid string concatenation in `StringBuilder.append()`

* Replace string concatenation w/ StringBuilder in loops
ulvii added a commit that referenced this pull request Nov 30, 2018
@ulvii
Revert "Improvement | Replace string concatenation with StringBuilder (…
4155941 
…#861)"

This reverts commit d7a7ce2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+2 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@ulvii ulvii ulvii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@simon04 @codecov-io @rene-ye @cheenamalhotra @ulvii @lilgreenbird