Added support to read SQL Warnings after ResultSet is read completely#785
Merged
cheenamalhotra merged 4 commits intomicrosoft:devfrom Aug 25, 2018
Merged
Added support to read SQL Warnings after ResultSet is read completely#785cheenamalhotra merged 4 commits intomicrosoft:devfrom
cheenamalhotra merged 4 commits intomicrosoft:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #785 +/- ##
============================================
+ Coverage 48.16% 48.18% +0.02%
+ Complexity 2785 2782 -3
============================================
Files 116 116
Lines 27858 27862 +4
Branches 4639 4641 +2
============================================
+ Hits 13418 13426 +8
+ Misses 12230 12208 -22
- Partials 2210 2228 +18
Continue to review full report at Codecov.
|
peterbae
reviewed
Aug 24, 2018
| // Clear out previous results | ||
| clearLastResult(); | ||
| // Clear out previous results only when clearFlag = true | ||
| if (clearFlag) |
Contributor
There was a problem hiding this comment.
add brackets even if there's only one line in the if statement
peterbae
reviewed
Aug 24, 2018
| @@ -1368,7 +1368,7 @@ final void clearLastResult() { | |||
| * | |||
Contributor
There was a problem hiding this comment.
Modify javadoc now that clearFlag is a parameter
peterbae
approved these changes
Aug 24, 2018
ulvii
approved these changes
Aug 25, 2018
cheenamalhotra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now JDBC driver does not capture any warnings after ResultSet is fully consumed and the TDS_MSG tokens are not consumed but are left unused in Stream.
Use Case:
Capturing warnings at the end of ResultSet is helpful for PolyBase External Data tables where rows could get rejected due to bad column values. This information is sent by SQL Server after ResultSet data.