Skip to content

Update Samples to be usable with Eclipse directly#679

Merged
cheenamalhotra merged 2 commits intomicrosoft:devfrom
cheenamalhotra:cleanup
Apr 26, 2018
Merged

Update Samples to be usable with Eclipse directly#679
cheenamalhotra merged 2 commits intomicrosoft:devfrom
cheenamalhotra:cleanup

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented Apr 18, 2018 •
edited
Loading

Updating Sample files to be able to add to Build Path and use directly in Eclipse.
Makes it easy to manage sample source code to test with driver changes and upcoming JDKs.
Also updated driver version used to 6.4.0.jre9

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 19, 2018 •
edited
Loading

Codecov Report

Merging #679 into dev will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #679      +/-   ##
============================================
+ Coverage     48.06%   48.14%   +0.08%     
- Complexity     2571     2578       +7     
============================================
  Files           112      113       +1     
  Lines         26582    26587       +5     
  Branches       4436     4436              
============================================
+ Hits          12777    12801      +24     
+ Misses        11667    11652      -15     
+ Partials       2138     2134       -4
Flag Coverage Δ Complexity Δ
#JDBC42 48.03% <ø> (?) 2576 <ø> (?)
#JDBC43 48.05% <ø> (-0.01%) 2571 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.91% <0%> (-0.22%) 88% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.29% <0%> (-0.19%) 0% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.53% <0%> (-0.1%) 0% <0%> (ø)
.../com/microsoft/sqlserver/jdbc/SQLServerJdbc42.java 40% <0%> (ø) 0% <0%> (?)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 78.01% <0%> (+0.16%) 5% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.67% <0%> (+0.19%) 240% <0%> (+1%) ⬆️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 50.85% <0%> (+0.24%) 157% <0%> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 45.66% <0%> (+0.26%) 66% <0%> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 76.85% <0%> (+0.27%) 25% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.14% <0%> (+0.43%) 245% <0%> (+4%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ad308...0f85d9d. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 6.5.2 milestone Apr 19, 2018
@rene-ye rene-ye self-requested a review April 24, 2018 23:49
@cheenamalhotra cheenamalhotra merged commit b3afe25 into microsoft:dev Apr 26, 2018
@cheenamalhotra cheenamalhotra deleted the cleanup branch April 26, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@cheenamalhotra @codecov-io @rene-ye @ulvii @peterbae