Skip to content

logger security fix#598

Merged
cheenamalhotra merged 1 commit intomicrosoft:devfrom
rene-ye:loggerSecurity
Jan 18, 2018
Merged

logger security fix#598
cheenamalhotra merged 1 commit intomicrosoft:devfrom
rene-ye:loggerSecurity

Conversation

@rene-ye
Copy link
Copy Markdown
Member

@rene-ye rene-ye commented Jan 5, 2018

don't print keystoresecrets

@rene-ye
logger security fix
bef12b2 
don't print keystoresecrets
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 5, 2018 •
edited
Loading

Codecov Report

Merging #598 into dev will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #598      +/-   ##
============================================
+ Coverage     46.54%   46.55%   +<.01%     
+ Complexity     2218     2217       -1     
============================================
  Files           108      108              
  Lines         25335    25336       +1     
  Branches       4177     4178       +1     
============================================
+ Hits          11792    11794       +2     
+ Misses        11514    11509       -5     
- Partials       2029     2033       +4
Flag Coverage Δ Complexity Δ
#JDBC41 46.32% <50%> (+0.04%) 2205 <0> (-4) ⬇️
#JDBC42 46.41% <50%> (+0.02%) 2214 <0> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.72% <50%> (+0.52%) 89 <0> (+1) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-1.49%) 11% <0%> (-1%)
...va/com/microsoft/sqlserver/jdbc/StreamColumns.java 87.83% <0%> (-1.36%) 21% <0%> (-1%)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 53.01% <0%> (-1.21%) 29% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 61.58% <0%> (-0.86%) 63% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.11% <0%> (-0.25%) 160% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.65% <0%> (-0.11%) 133% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.93% <0%> (-0.07%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (ø) 16% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.73% <0%> (+0.04%) 241% <0%> (+1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598292b...bef12b2. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 6.4.0 milestone Jan 8, 2018
@cheenamalhotra cheenamalhotra merged commit 4c361c8 into microsoft:dev Jan 18, 2018
@rene-ye rene-ye deleted the loggerSecurity branch February 6, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rene-ye @codecov-io @cheenamalhotra @lilgreenbird