Skip to content

Update JDBC4.3 branch with latest dev changes#586

Merged
cheenamalhotra merged 26 commits intomicrosoft:JDBC4.3from
AfsanehR-zz:JDBC4.3
Dec 15, 2017
Merged

Update JDBC4.3 branch with latest dev changes#586
cheenamalhotra merged 26 commits intomicrosoft:JDBC4.3from
AfsanehR-zz:JDBC4.3

Conversation

@AfsanehR-zz
Copy link
Copy Markdown
Contributor

@AfsanehR-zz AfsanehR-zz commented Dec 15, 2017

No description provided.

xiangyushawn and others added 26 commits August 1, 2017 17:48
@xiangyushawn
use matrix to test against both SQL Server 2016 and 2008
f6277eb
@xiangyushawn
miss a ;
0587b66
@xiangyushawn
use matrix and init to start services
e650225
@xiangyushawn
simplify appveyor configuration
f4c7604
@xiangyushawn
fix 2 test failures against sql server 2008
fddcb30
@TobiasSQL
Fix for EnablePrepareOnFirstPreparedStatementCall with statement pooling
89c92b7 
turned off.
@peterbae
fix for 477
0046d3c
@peterbae
add check for updatable resultsets.
c006af2
@xiangyushawn
Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into te…
6607087 
…st-agaist-both-2008-and-2016
@xiangyushawn
use preparedStatementHandleCache with database name
21fde63
@xiangyushawn
retrieve db name without check connection
a9b6a7c
@cheenamalhotra
Adding changes to logger implementation for avoiding logger lookup
3a60d34
@xiangyushawn
update ADAL4J version to 1.3.0 and also add it into readme file based…
40a9bf5 
… on request
@xiangyushawn
Merge pull request microsoft#564 from v-xiangs/update-dependencies
8344415 
update ADAL4J version to 1.3.0 and also add it into readme file based on request
@xiangyushawn
Merge pull request microsoft#561 from v-xiangs/v-xiangs-handle-DBName
ba22e94 
Use database name as part of the key for handle cache
@xiangyushawn
Merge pull request microsoft#513 from Microsoft/metadataCaching
01e8013 
Fix for EnablePrepareOnFirst...Call with statement pooling turned off
@xiangyushawn
Merge pull request microsoft#428 from v-xiangs/test-agaist-both-2008-…
907e1a6 
…and-2016

use matrix to test against both SQL Server 2016 and 2008
@peterbae
Merge pull request microsoft#552 from peterbae/github-477
a8ed6f6 
Add check for deleted rows in resultsets for scrollable & updatable resultsets
@cheenamalhotra
Merge pull request microsoft#563 from cheenamalhotra/staticLogger
9fe90f7 
Adding static loggers back to sub classes for avoiding logger lookup
@peterbae
Fix issue with rowDeleted() causing issues with testing
823f08e
@peterbae
Revert "Fix issue with rowDeleted() causing issues with testing"
4c90c8e 
This reverts commit 823f08e.
@peterbae
Reverting PR 563, due to test failures
557fdf3
@peterbae
6.3.6 preview release
6fdab44
@peterbae
Merge pull request microsoft#574 from peterbae/github-477
ab733d3 
Reverting PR 552
@peterbae
Merge pull request microsoft#575 from peterbae/peter-6.3.6-release
2c357ce 
6.3.6 preview release document changes
@AfsanehR-zz
Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into JD…
5846c8f 
…BC4.3

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithNullTest.java
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 15, 2017 •
edited
Loading

Codecov Report

Merging #586 into JDBC4.3 will decrease coverage by 0.06%.
The diff coverage is 81.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             JDBC4.3    #586      +/-   ##
============================================
- Coverage      46.56%   46.5%   -0.07%     
  Complexity      2219    2219              
============================================
  Files            108     108              
  Lines          25373   25387      +14     
  Branches        4177    4179       +2     
============================================
- Hits           11816   11805      -11     
- Misses         11533   11552      +19     
- Partials        2024    2030       +6
Flag Coverage Δ Complexity Δ
#JDBC42 46.33% <81.48%> (-0.1%) 2209 <7> (+1)
#JDBC43 46.48% <81.48%> (+0.03%) 2217 <7> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
...a/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.38% <ø> (-0.82%) 238 <0> (-6)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.49% <100%> (+0.02%) 278 <1> (+1) ⬆️
...a/com/microsoft/sqlserver/jdbc/SQLServerNClob.java 100% <100%> (ø) 4 <3> (+1) ⬆️
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 35.4% <100%> (-0.08%) 55 <0> (ø)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.4% <73.33%> (+0.11%) 160 <0> (+1) ⬆️
...va/com/microsoft/sqlserver/jdbc/SQLServerClob.java 28.26% <80%> (+0.31%) 4 <3> (+1) ⬆️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 53.01% <0%> (-2.41%) 29% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-1.49%) 11% <0%> (-1%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2bbef...5846c8f. Read the comment docs.

@cheenamalhotra cheenamalhotra merged commit 29a8a3a into microsoft:JDBC4.3 Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+1 more reviewer

@xiangyushawn xiangyushawn xiangyushawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AfsanehR-zz @codecov-io @cheenamalhotra @xiangyushawn @lilgreenbird @TobiasSQL @peterbae