Skip to content

update sendTimeAsDateTime default property to false.#572

Merged
cheenamalhotra merged 1 commit intomicrosoft:devfrom
AfsanehR-zz:sendTimeAsDateTime_property
Jan 12, 2018
Merged

update sendTimeAsDateTime default property to false.#572
cheenamalhotra merged 1 commit intomicrosoft:devfrom
AfsanehR-zz:sendTimeAsDateTime_property

Conversation

@AfsanehR-zz
Copy link
Copy Markdown
Contributor

@AfsanehR-zz AfsanehR-zz commented Dec 6, 2017

After merging this pr, the default behavior of the driver would be to send Time as time.
Reference for the current behavior in here.

Will fix issue #559

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 6, 2017 •
edited
Loading

Codecov Report

Merging #572 into dev will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #572      +/-   ##
============================================
- Coverage     46.56%   46.46%   -0.11%     
+ Complexity     2221     2217       -4     
============================================
  Files           108      108              
  Lines         25340    25340              
  Branches       4178     4178              
============================================
- Hits          11800    11774      -26     
- Misses        11505    11545      +40     
+ Partials       2035     2021      -14
Flag Coverage Δ Complexity Δ
#JDBC41 46.21% <100%> (-0.13%) 2202 <0> (-11)
#JDBC42 46.36% <100%> (-0.08%) 2212 <0> (-1)
Impacted Files Coverage Δ Complexity Δ
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 77.22% <100%> (ø) 25 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.2% <0%> (-1.66%) 28% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 61.37% <0%> (-1.08%) 63% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.11% <0%> (-0.33%) 244% <0%> (-3%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.33% <0%> (-0.3%) 0% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.11% <0%> (-0.25%) 160% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.87% <0%> (-0.13%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.58% <0%> (-0.07%) 240% <0%> (+1%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.73% <0%> (-0.04%) 276% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.75% <0%> (+0.1%) 134% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe90f7...f1674af. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 6.4.0 milestone Jan 8, 2018
@cheenamalhotra cheenamalhotra merged commit 697757b into microsoft:dev Jan 12, 2018
@AfsanehR-zz AfsanehR-zz mentioned this pull request Jan 23, 2018
Closed
@AfsanehR-zz AfsanehR-zz deleted the sendTimeAsDateTime_property branch February 2, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AfsanehR-zz @codecov-io @cheenamalhotra @lilgreenbird