Update code to compile with AKV v1.0.0#397
Merged
xiangyushawn merged 6 commits intomicrosoft:devfrom Jul 21, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #397 +/- ##
============================================
+ Coverage 40.12% 40.16% +0.04%
+ Complexity 1890 1888 -2
============================================
Files 107 107
Lines 24482 24472 -10
Branches 4038 4039 +1
============================================
+ Hits 9823 9830 +7
+ Misses 12820 12798 -22
- Partials 1839 1844 +5
Continue to review full report at Codecov.
|
AfsanehR-zz
approved these changes
Jul 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue #389
after updating to azure-keyvault v1.0.0, the project breaks. The PR fixes it.
However, it will also break user's existing programs that use AKV. We will need to document this breaking change:
Previous, in order to construct
SQLServerColumnEncryptionAzureKeyVaultProviderobject, client code needs to construct aSQLServerKeyVaultAuthenticationCallbackobject first by implementingSQLServerKeyVaultAuthenticationCallbackinterface (withclientIDandclientKey) and also provide anExecutorServiceobject. By doing so, user needs to handleSQLServerKeyVaultAuthenticationCallbackinterface and take care of theExecutorServiceobject (e.g. shutdown) by themselves.Now, with the latest version of AKV, user can create
SQLServerColumnEncryptionAzureKeyVaultProviderobject directly withclientIDandclientKey. Without implementing interface or providingExecutorService, it reduces complexity on user side.