Skip to content

Set fmtonly on to support complex query#373

Merged
xiangyushawn merged 2 commits intomicrosoft:devfrom
xiangyushawn:newdev-SET-FMTONLY-ON-to-support-complex-query
Jul 21, 2017
Merged

Set fmtonly on to support complex query#373
xiangyushawn merged 2 commits intomicrosoft:devfrom
xiangyushawn:newdev-SET-FMTONLY-ON-to-support-complex-query

Conversation

@xiangyushawn
Copy link
Copy Markdown
Contributor

@xiangyushawn xiangyushawn commented Jul 6, 2017

new PR equivalent to #350 which fixes #343

the original way of using Set fmtonly on does not work with complex query or multiple tables. This PR uses a workaround by using LEFT JOIN query.

What the PR does is, converting the original query to a LEFT JOIN query and retrieve parameter metadata.

@xiangyushawn xiangyushawn mentioned this pull request Jul 6, 2017
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 6, 2017 •
edited
Loading

Codecov Report

Merging #373 into dev will decrease coverage by 0.12%.
The diff coverage is 4.34%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #373      +/-   ##
============================================
- Coverage     40.16%   40.03%   -0.13%     
+ Complexity     1892     1887       -5     
============================================
  Files           107      107              
  Lines         24482    24518      +36     
  Branches       4038     4045       +7     
============================================
- Hits           9833     9817      -16     
- Misses        12815    12862      +47     
- Partials       1834     1839       +5
Flag Coverage Δ Complexity Δ
#JDBC41 39.97% <4.34%> (-0.08%) 1881 <0> (-2)
#JDBC42 39.86% <4.34%> (-0.15%) 1876 <0> (-9)
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 23.97% <4.34%> (-1.56%) 30 <0> (ø)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-3.38%) 16% <0%> (-1%)
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 47.4% <0%> (-1.49%) 9% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.66% <0%> (-0.45%) 57% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.21% <0%> (-0.29%) 211% <0%> (+1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.2% <0%> (-0.22%) 46% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.23% <0%> (-0.17%) 187% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd68b5...a04d9ad. Read the comment docs.

@ajlam ajlam added this to the 6.3.0 milestone Jul 17, 2017
@xiangyushawn xiangyushawn merged commit 999cd00 into microsoft:dev Jul 21, 2017
@xiangyushawn xiangyushawn deleted the newdev-SET-FMTONLY-ON-to-support-complex-query branch July 21, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AfsanehR-zz AfsanehR-zz AfsanehR-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.3.0

Development

Successfully merging this pull request may close these issues.

Incorrect parameter count for INSERT with subquery

6 participants

@xiangyushawn @codecov-io @AfsanehR-zz @lilgreenbird @msftclas @ajlam