String index out of range parameter metadata#353
Merged
xiangyushawn merged 3 commits intomicrosoft:RTW_6.2.0from Jun 26, 2017
Merged
Conversation
xiangyushawn
added a commit
to xiangyushawn/mssql-jdbc-xiangs
that referenced
this pull request
Jun 21, 2017
Codecov Report
@@ Coverage Diff @@
## RTW_6.2.0 #353 +/- ##
===============================================
- Coverage 40.05% 40.04% -0.01%
- Complexity 1878 1879 +1
===============================================
Files 107 107
Lines 24480 24482 +2
Branches 4036 4037 +1
===============================================
- Hits 9805 9804 -1
+ Misses 12838 12833 -5
- Partials 1837 1845 +8
Continue to review full report at Codecov.
|
ahmad-ibra
approved these changes
Jun 26, 2017
| */ | ||
| @Test | ||
| public void testQueryWithSpaceAndEndCommentMarkInColumnName() throws SQLServerException { | ||
| pstmt = connection.prepareStatement("SELECT [c1*/someStrintg withspace] from " + spaceTable); |
There was a problem hiding this comment.
theres an extra t character in "someStrintg withspace"
Contributor
Author
There was a problem hiding this comment.
done, thank you.
| } | ||
|
|
||
| private static void createSpaceTable() throws SQLException { | ||
| stmt.execute("Create table " + spaceTable + " (" + "[c1*/someStrintg withspace] char(50) not null," + "c2 varchar(20) not null," |
There was a problem hiding this comment.
theres an extra t character in "someStrintg withspace"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix an existing bug when getting parameter metadata and column name has end comment mark and space. Better to merge this PR as soon as possible.