Skip to content

Set fmtonly on to support complex query#350

Closed
xiangyushawn wants to merge 7 commits intomicrosoft:devfrom
xiangyushawn:SET-FMTONLY-ON-to-support-complex-query
Closed

Set fmtonly on to support complex query#350
xiangyushawn wants to merge 7 commits intomicrosoft:devfrom
xiangyushawn:SET-FMTONLY-ON-to-support-complex-query

Conversation

@xiangyushawn
Copy link
Copy Markdown
Contributor

@xiangyushawn xiangyushawn commented Jun 19, 2017 •
edited
Loading

fix issue #343

the original way of using Set fmtonly on does not work with complex query or multiple tables. This PR uses a workaround by using LEFT JOIN query.

What the PR does is, converting the original query to a LEFT JOIN query and retrieve parameter metadata.

@xiangyushawn xiangyushawn mentioned this pull request Jun 19, 2017
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 19, 2017 •
edited
Loading

Codecov Report

Merging #350 into dev will increase coverage by 0.04%.
The diff coverage is 4.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #350      +/-   ##
============================================
+ Coverage     37.23%   37.28%   +0.04%     
- Complexity     1666     1700      +34     
============================================
  Files           103      103              
  Lines         23667    23705      +38     
  Branches       3880     3888       +8     
============================================
+ Hits           8813     8839      +26     
- Misses        13261    13301      +40     
+ Partials       1593     1565      -28
Flag Coverage Δ Complexity Δ
#JDBC41 37.19% <4.25%> (+0.16%) 1694 <0> (+38) ⬆️
#JDBC42 37.23% <4.25%> (+0.06%) 1698 <0> (+35) ⬆️
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 23.97% <4.25%> (-1.68%) 30 <0> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 48.97% <0%> (-0.15%) 211% <0%> (ø)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 29.01% <0%> (-0.12%) 47% <0%> (+1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 37.03% <0%> (+0.06%) 0% <0%> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 46.11% <0%> (+0.06%) 0% <0%> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 44% <0%> (+0.08%) 254% <0%> (+2%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.36% <0%> (+0.12%) 195% <0%> (+8%) ⬆️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 33.8% <0%> (+0.17%) 94% <0%> (+4%) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 45.39% <0%> (+0.23%) 61% <0%> (+1%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.59% <0%> (+0.51%) 137% <0%> (+8%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244c59d...037f054. Read the comment docs.

@xiangyushawn xiangyushawn reopened this Jul 5, 2017
@xiangyushawn xiangyushawn mentioned this pull request Jul 6, 2017
Merged
@xiangyushawn
Copy link
Copy Markdown
Contributor Author

xiangyushawn commented Jul 6, 2017

new PR #373 is created to get rid of Revert-MetadataCaching commit

@xiangyushawn xiangyushawn deleted the SET-FMTONLY-ON-to-support-complex-query branch July 6, 2017 20:45
@ecki ecki mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xiangyushawn @codecov-io @lilgreenbird @msftclas @ajlam