Skip to content

Update JavaDocs and validate javadocs.#327

Closed
v-nisidh wants to merge 3 commits intomicrosoft:devfrom
v-nisidh:javadoc
Closed

Update JavaDocs and validate javadocs.#327
v-nisidh wants to merge 3 commits intomicrosoft:devfrom
v-nisidh:javadoc

Conversation

@v-nisidh
Copy link
Copy Markdown
Contributor

@v-nisidh v-nisidh commented Jun 3, 2017

Update JavaDocs & make javadocs checking part of build process.

@v-nisidh
Update JavaDocs and validate javadocs.
173119f 
Update JavaDocs & make javadocs checking part of build process.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 3, 2017 •
edited
Loading

Codecov Report

Merging #327 into dev will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #327      +/-   ##
============================================
- Coverage     37.24%   37.17%   -0.08%     
+ Complexity     1667     1661       -6     
============================================
  Files           103      103              
  Lines         23673    23673              
  Branches       3882     3882              
============================================
- Hits           8818     8800      -18     
- Misses        13262    13289      +27     
+ Partials       1593     1584       -9
Flag Coverage Δ Complexity Δ
#JDBC41 37.06% <ø> (-0.03%) 1657 <ø> (-1)
#JDBC42 37.07% <ø> (-0.05%) 1658 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...com/microsoft/sqlserver/jdbc/dns/DNSRecordSRV.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 43.92% <ø> (ø) 252 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 46.83% <ø> (ø) 64 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.6% <0%> (-1.63%) 28% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 26.78% <0%> (-0.46%) 183% <0%> (-4%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.46% <0%> (-0.23%) 55% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 36.75% <0%> (-0.21%) 0% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 46.11% <0%> (-0.11%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 49.26% <0%> (+1.47%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76b0ca...173119f. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 3, 2017 •
edited
Loading

Codecov Report

Merging #327 into dev will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev    #327      +/-   ##
===========================================
- Coverage     37.24%   37.2%   -0.05%     
+ Complexity     1667    1664       -3     
===========================================
  Files           103     103              
  Lines         23673   23667       -6     
  Branches       3882    3880       -2     
===========================================
- Hits           8818    8806      -12     
- Misses        13262   13270       +8     
+ Partials       1593    1591       -2
Flag Coverage Δ Complexity Δ
#JDBC41 37.11% <ø> (+0.02%) 1660 <ø> (+2) ⬆️
#JDBC42 37.07% <ø> (-0.05%) 1657 <ø> (-1)
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 43.92% <ø> (ø) 252 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 46.83% <ø> (ø) 64 <0> (ø) ⬇️
...com/microsoft/sqlserver/jdbc/dns/DNSRecordSRV.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 31.38% <0%> (-0.87%) 37% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 33.36% <0%> (-0.27%) 90% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 36.82% <0%> (-0.14%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.15% <0%> (-0.09%) 186% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.04% <0%> (-0.08%) 211% <0%> (-1%)
src/main/java/com/microsoft/sqlserver/jdbc/AE.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.68% <0%> (ø) 55% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76b0ca...bc7db08. Read the comment docs.

@v-nisidh v-nisidh requested a review from xiangyushawn June 3, 2017 01:03
@v-nisidh
Update for JavaDoc Warning
ba9787e 
Update for JavaDoc Warning
@xiangyushawn
Copy link
Copy Markdown
Contributor

xiangyushawn commented Jun 12, 2017 •
edited
Loading

for all the javadoc fixes, they are already fixed in RTW branch by PR #299.

also, in my humble opinion, PR #299 uses {@literal <} instead of &lt;, that's more readable to me.

@xiangyushawn
Copy link
Copy Markdown
Contributor

xiangyushawn commented Jun 12, 2017 •
edited
Loading

the changes in pom.xml look fine to me

@v-nisidh
Added literal annotiontion
bc7db08 
Added literal annotiontion as per review comment.
@xiangyushawn xiangyushawn mentioned this pull request Jun 13, 2017
Merged
@xiangyushawn
Copy link
Copy Markdown
Contributor

xiangyushawn commented Jun 13, 2017

closing this PR because new PR based on this implementation is created to RTW branch #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangyushawn xiangyushawn Awaiting requested review from xiangyushawn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@v-nisidh @codecov-io @xiangyushawn @lilgreenbird @msftclas @ajlam