Get local host name before opening TDSChannel#324
Merged
Suraiya-Hameed merged 4 commits intomicrosoft:RTW_6.2.0from Jun 12, 2017
Merged
Get local host name before opening TDSChannel#324Suraiya-Hameed merged 4 commits intomicrosoft:RTW_6.2.0from
Suraiya-Hameed merged 4 commits intomicrosoft:RTW_6.2.0from
Conversation
Codecov Report
@@ Coverage Diff @@
## RTW_6.2.0 #324 +/- ##
===============================================
- Coverage 37.17% 37.15% -0.02%
+ Complexity 1670 1666 -4
===============================================
Files 103 103
Lines 23663 23664 +1
Branches 3918 3918
===============================================
- Hits 8796 8793 -3
Misses 13278 13278
- Partials 1589 1593 +4
Continue to review full report at Codecov.
|
xiangyushawn
approved these changes
Jun 1, 2017
v-nisidh
approved these changes
Jun 2, 2017
| } | ||
|
|
||
| // Before opening the TDSChannel, calculate local hostname | ||
| // as the InetAddress.getLocalHost() takes more than usual time in certian OS and JVM combination, it avoids connection loss |
Contributor
There was a problem hiding this comment.
Suggestion: I think it should be good if we mention that in Sierra getLocalHost takes lot of time.
Contributor
There was a problem hiding this comment.
Suggestion: As you are moving condition we can reduce complexity by 1 by using StringUtils.isEmpty()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177