Tvp time 4 fix rtw#317
Merged
xiangyushawn merged 3 commits intomicrosoft:RTW_6.2.0from May 29, 2017
Merged
Conversation
…object, which is converted to String later on and precision is removed.
Codecov Report
@@ Coverage Diff @@
## RTW_6.2.0 #317 +/- ##
===============================================
- Coverage 37.17% 37.15% -0.03%
+ Complexity 1668 1665 -3
===============================================
Files 103 103
Lines 23661 23663 +2
Branches 3917 3918 +1
===============================================
- Hits 8797 8793 -4
- Misses 13273 13277 +4
- Partials 1591 1593 +2
Continue to review full report at Codecov.
|
Suraiya-Hameed
approved these changes
May 29, 2017
| try { | ||
| rowData[i] = sourceResultSet.getObject(i + 1); | ||
| if (java.sql.Types.TIME == sourceResultSet.getMetaData().getColumnType(i + 1)) { | ||
| rowData[i] = sourceResultSet.getTimestamp(i + 1); |
Contributor
There was a problem hiding this comment.
Looks good. can you just add a comment explaining why getTimestamp is used?
Contributor
Author
There was a problem hiding this comment.
Thank you! I added comment for it. Will merge the PR soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue #315