Add comprehensive test suite for mixed-type vector columns (float32 and float16)#2907
Merged
muskan124947 merged 4 commits intomainfrom Mar 11, 2026
Merged
Add comprehensive test suite for mixed-type vector columns (float32 and float16)#2907muskan124947 merged 4 commits intomainfrom
muskan124947 merged 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2907 +/- ##
============================================
- Coverage 60.65% 60.61% -0.04%
+ Complexity 4926 4910 -16
============================================
Files 151 151
Lines 35000 35000
Branches 5854 5854
============================================
- Hits 21229 21216 -13
Misses 10938 10938
- Partials 2833 2846 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an expanded test suite to validate driver behavior when FLOAT32 and FLOAT16 vector columns coexist in the same schema (requires vectorTypeSupport=v2), covering both “regular” JDBC paths and bulk-copy paths.
Changes:
- Added a new CSV resource containing mixed FLOAT32/FLOAT16 vector column data for bulk copy scenarios.
- Extended FLOAT16 bulk-copy tests with mixed-type (FLOAT32+FLOAT16) table-to-table, CSV, ISQLServerBulkData, and batch-insert coverage.
- Extended FLOAT16 vector tests with mixed-type table scenarios (CRUD, null handling, metadata, TVPs, stored procedures, transactions, temp tables, views, UDFs).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/test/resources/BulkCopyCSVTestInputMixedVectorType.csv | New CSV input for mixed FLOAT32/FLOAT16 vector bulk-copy tests. |
| src/test/java/com/microsoft/sqlserver/jdbc/datatypes/vector/bulkcopy/VectorFloat16BulkCopyTest.java | Adds a nested mixed-type bulk-copy test suite alongside existing FLOAT16 bulk-copy coverage. |
| src/test/java/com/microsoft/sqlserver/jdbc/datatypes/vector/VectorFloat16Test.java | Adds a nested mixed-type vector test suite covering JDBC operations, metadata, TVPs, procs, and transactions. |
You can also share your feedback on Copilot code review. Take the survey.
muskan124947
changed the title
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…at32 and vice versa
machavan
approved these changes
Mar 11, 2026
Ananya2
approved these changes
Mar 11, 2026
divang
reviewed
Mar 11, 2026
Contributor
divang
left a comment
divang
left a comment
There was a problem hiding this comment.
Please check if there is any duplicate logic in the test cases, such as getMixedConnectionString() or other similar scenarios.
github-project-automation
Bot
moved this from In progress
to Closed/Merged PRs
in MSSQL JDBC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building on the existing VECTOR(FLOAT316) support, this PR expands the test suite to validate driver behavior when FLOAT32 and FLOAT16 vector columns coexist within the same schema. This requires
vectorTypeSupport=v2.The tests cover both standard JDBC execution paths and bulk copy scenarios to ensure correct functionality across mixed vector types.
Changes
ISQLServerBulkDataRelated PRs
#2853
#2868
#2899
#2898
Performance Testing
(Tests performed using FLOAT32 vectors with
dimensionCount = 1998. Timings include both serialization and deserialization overhead.)