Skip to content

Fixed possible resource leak#287

Merged
AfsanehR-zz merged 2 commits intomicrosoft:devfrom
pierresouchay:dev
May 18, 2017
Merged

Fixed possible resource leak#287
AfsanehR-zz merged 2 commits intomicrosoft:devfrom
pierresouchay:dev

Conversation

@pierresouchay
Copy link
Copy Markdown
Contributor

@pierresouchay pierresouchay commented May 12, 2017

No description provided.

@msftclas
Copy link
Copy Markdown

msftclas commented May 12, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 12, 2017 •
edited
Loading

Codecov Report

Merging #287 into dev will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #287      +/-   ##
============================================
- Coverage     37.36%   37.15%   -0.21%     
+ Complexity     1671     1660      -11     
============================================
  Files           103      103              
  Lines         23671    23673       +2     
  Branches       3882     3882              
============================================
- Hits           8844     8796      -48     
- Misses        13234    13293      +59     
+ Partials       1593     1584       -9
Flag Coverage Δ Complexity Δ
#JDBC41 37.05% <0%> (-0.11%) 1654 <0> (-10)
#JDBC42 37.05% <0%> (-0.21%) 1658 <0> (-6)
Impacted Files Coverage Δ Complexity Δ
...com/microsoft/sqlserver/jdbc/dns/DNSUtilities.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.6% <0%> (-1.63%) 28% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 46.08% <0%> (-0.79%) 0% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 45.15% <0%> (-0.71%) 60% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.46% <0%> (-0.67%) 55% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 26.86% <0%> (-0.38%) 184% <0%> (-3%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 36.75% <0%> (-0.28%) 0% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 33.45% <0%> (-0.18%) 89% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 48.9% <0%> (-0.15%) 209% <0%> (-3%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c706d55...d96f13a. Read the comment docs.

@pierresouchay pierresouchay mentioned this pull request May 18, 2017
Merged
@AfsanehR-zz
Copy link
Copy Markdown
Contributor

AfsanehR-zz commented May 18, 2017

Thanks for the fix @pierresouchay and quick response!

@AfsanehR-zz AfsanehR-zz merged commit f4b87c3 into microsoft:dev May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pierresouchay @msftclas @codecov-io @AfsanehR-zz @lilgreenbird