Send user agent info as a new feature extension to server#2848
Merged
Send user agent info as a new feature extension to server#2848
Conversation
machavan
requested review from
Ananya2,
David-Engel,
divang and
muskan124947
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2848 +/- ##
============================================
+ Coverage 56.35% 56.39% +0.04%
- Complexity 4531 4550 +19
============================================
Files 151 151
Lines 34445 34494 +49
Branches 5741 5751 +10
============================================
+ Hits 19410 19454 +44
- Misses 12415 12421 +6
+ Partials 2620 2619 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
muskan124947
previously approved these changes
Nov 20, 2025
divang
previously approved these changes
Nov 20, 2025
Ananya2
previously approved these changes
Nov 20, 2025
David-Engel
reviewed
Nov 21, 2025
Collaborator
David-Engel
left a comment
David-Engel
left a comment
There was a problem hiding this comment.
Minor comment. Otherwise, LGTM.
machavan
dismissed stale reviews from Ananya2, divang, and muskan124947
via
d919144
muskan124947
previously approved these changes
Nov 26, 2025
Ananya2
previously approved these changes
Nov 26, 2025
divang
previously approved these changes
Nov 26, 2025
machavan
dismissed stale reviews from divang, Ananya2, and muskan124947
via
ab3cc28
muskan124947
approved these changes
Nov 27, 2025
divang
approved these changes
Nov 27, 2025
Ananya2
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
By enhancing telemetry for SQL drivers, we can achieve a more nuanced understanding of the operating environments in use. This capability enables us to make strategic decisions about testing and support, ultimately improving our efficiency and reducing costs. Adopting a structured and extensible approach to telemetry collection will ensure we gather the most relevant and useful data, facilitating continuous improvement in our processes.
The user agent information will be transported to the SQL Server via a new TDS Feature Extension (FE) in the LOGIN7 TDS message:
Name: USERAGENT
Identifier: 0x10
Data Length: max 256 bytes
Data: + UCS-2 encoded String
User agent string format:
<user agent version>|<driver type>|<driver version>|<os type>|<os version>|<architecture>|<runtime>Sample
1|MS-JDBC|13.2.0|Windows|Windows 10.0.22600.0|amd64|OpenJDK 64-Bit Server VM 21.0.4+7-LTSTesting:
-Added a new test to validate the generated user agent string max length
-Verified with SQL databases that are both disabled and enabled with accepting and handling this new user agent FE.
-All existing test cases exercise this code path since each login packet will include this new feature extension.