Revert "Use sys.all_objects for accurate function and procedure filtering"#2751
Merged
muskan124947 merged 1 commit intomainfrom Aug 29, 2025
Merged
Conversation
Ananya2
approved these changes
Aug 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2751 +/- ##
============================================
- Coverage 51.51% 51.51% -0.01%
+ Complexity 4081 4066 -15
============================================
Files 149 149
Lines 34268 34241 -27
Branches 5725 5718 -7
============================================
- Hits 17654 17638 -16
+ Misses 14125 14113 -12
- Partials 2489 2490 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
machavan
approved these changes
Aug 28, 2025
This was referenced Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2705
This change is being reverted due to differences in behavior observed between:
Specifically:
getProcedures() and getFunctions() return procedure/function names without numbered suffixes, since sys.all_objects does not expose numbered procedures.
In contrast, getProcedureColumns() and getFunctionColumns() query sp_sproc_columns, which does return numbered procedures, leading to inconsistencies across these APIs.
There was an effort done to make getProcedureColumns() and getFunctionColumns() work in PR#2743.
This PR addressed these differences, but SQL Server still supports numbered procedures, and users can benefit from grouped procedures (see here : sp_proc_columns)
To maintain compatibility and avoid unexpected discrepancies, this PR reverts #2705 and restores the original behavior.