Update getProcedureColumns() and getFunctionColumns() to return name without numbered prefixes#2743
Closed
muskan124947 wants to merge 3 commits intomainfrom
Closed
Update getProcedureColumns() and getFunctionColumns() to return name without numbered prefixes#2743muskan124947 wants to merge 3 commits intomainfrom
muskan124947 wants to merge 3 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2743 +/- ##
============================================
+ Coverage 51.51% 51.55% +0.03%
- Complexity 4081 4082 +1
============================================
Files 149 149
Lines 34268 34276 +8
Branches 5725 5727 +2
============================================
+ Hits 17654 17670 +16
+ Misses 14125 14110 -15
- Partials 2489 2496 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
machavan
reviewed
Aug 20, 2025
| /** | ||
| * Provides filter to remove numbered prefixes from procedure names. | ||
| */ | ||
| class ColumnNameFilter extends ColumnFilter { |
Contributor
There was a problem hiding this comment.
can rename to ProcNameFilter
Contributor
Author
There was a problem hiding this comment.
It will be used for getFunctionColumns() also
muskan124947
changed the title
divang
approved these changes
Aug 21, 2025
This was referenced Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses GitHub reported issue : Cannot relate procedures to procedure columns (same with functions) #2739
Post fixing the issue Use sys.all_objects for accurate function and procedure filtering #2705 : where both DatabaseMetadata.getProcedures and DatabaseMetadata.getFunctions returns correct result. With this change object names got updated as mentioned below:
So, DatabaseMetadata.getProcedureColumns and DatabaseMetadata.getFunctionColumns should also return similar pattern.
Currently it returns the resultset where procedure and function names were appended with a numbered suffix (;1).
As per the documentation : “Numbered procedures are deprecated. Avoid using them in new development work, and plan to modify applications that currently use them.”
Fix
Updated the implementation of getProcedureColumns() and getFunctionColumns() to filter out numbered suffixes from procedure/function names.
This ensures that the returned column metadata reflects only the expected procedure/function names.
Testing