Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2643 +/- ##
=========================================
Coverage 51.63% 51.63%
- Complexity 4003 4012 +9
=========================================
Files 147 147
Lines 33757 33759 +2
Branches 5639 5640 +1
=========================================
+ Hits 17429 17432 +3
- Misses 13871 13888 +17
+ Partials 2457 2439 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
David-Engel
reviewed
Apr 18, 2025
Collaborator
There was a problem hiding this comment.
The code changes look fine. Just some adjustments needed to the new test.
Also, please include a description on all PRs. Descriptions should include references to source issues and enough details for a reviewer to understand the purpose and goal of the PR before looking at the code changes.
David-Engel
approved these changes
Apr 21, 2025
Collaborator
David-Engel
left a comment
David-Engel
left a comment
There was a problem hiding this comment.
Please don't forget to update the description, too! Thanks!
…is specified; add validation test case.
Ananya2
force-pushed
the
users/anagarg/issue#2639
branch
from
9ee0d34 to
5bae521
Compare
machavan
approved these changes
Apr 23, 2025
divang
approved these changes
Apr 23, 2025
Contributor
Author
|
ADO pipeline: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Issue: #2639
Fixed incorrect filtering behavior in DatabaseMetaData.getSchemas when a specific catalog name is provided. Previously, the driver returned system/predefined schemas with a null catalog even when a catalog was specified, violating the JDBC specification. This update ensures that only schemas belonging to the specified catalog are returned, and system schemas without a catalog are properly excluded from the result set.