Fixed exception type to SQLFeatureNotSupported#2583
Merged
Conversation
machavan
changed the title
machavan
requested review from
David-Engel,
Jeffery-Wasty,
codewatchzen,
divang,
lilgreenbird and
tkyc
Contributor
|
/azp run public-mssql-jdbc.windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run public-mssql-jdbc.linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run CI-MacOS |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
============================================
- Coverage 51.67% 51.57% -0.10%
+ Complexity 4011 3997 -14
============================================
Files 147 147
Lines 33759 33760 +1
Branches 5640 5640
============================================
- Hits 17445 17412 -33
- Misses 13861 13891 +30
- Partials 2453 2457 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lilgreenbird
approved these changes
Jan 15, 2025
Jeffery-Wasty
approved these changes
Jan 21, 2025
David-Engel
previously approved these changes
Jan 23, 2025
lilgreenbird
approved these changes
Jan 24, 2025
Ananya2
force-pushed
the
dev/machavan/issue2580
branch
from
0bb9238 to
e719236
Compare
divang
approved these changes
Apr 24, 2025
David-Engel
approved these changes
Apr 24, 2025
github-project-automation
Bot
moved this from Under Peer Review
to Closed/Merged PRs
in MSSQL JDBC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2580
Fixed exception type to SQLfeatureNotSupported as per the the java.sql.Connection API doc: https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#releaseSavepoint-java.sql.Savepoint-
Testing: