Fixed issue for finding mssql-jdbc.properties location in test environments#2579
Merged
Fixed issue for finding mssql-jdbc.properties location in test environments#2579
mssql-jdbc.properties location in test environments#2579Conversation
…utOfBoundsExcelption
Jeffery-Wasty
requested review from
Ananya2,
divang,
lilgreenbird,
machavan,
muskan124947 and
tkyc
tkyc
reviewed
Jan 10, 2025
tkyc
reviewed
Jan 10, 2025
machavan
reviewed
Jan 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
============================================
+ Coverage 51.22% 51.37% +0.15%
- Complexity 3953 3978 +25
============================================
Files 147 147
Lines 33657 33665 +8
Branches 5624 5627 +3
============================================
+ Hits 17241 17296 +55
+ Misses 13999 13936 -63
- Partials 2417 2433 +16 ☔ View full report in Codecov by Sentry. |
machavan
previously approved these changes
Feb 6, 2025
Jeffery-Wasty
changed the title
mssql-jdbc.properties location logicmssql-jdbc.properties location logic
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java:287
- The variable 'locationSuffix' is defined but not used consistently. Consider using 'locationSuffix.length()' instead of hardcoding the length value (16) on line 291.
String locationSuffix = "target/classes/";
machavan
approved these changes
Feb 11, 2025
divang
approved these changes
Feb 11, 2025
Contributor
|
ADO test runs were good for this change. |
lilgreenbird
changed the title
mssql-jdbc.properties location logicmssql-jdbc.properties location in test environments
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for finding the
mssql-jdbc.propertiesfile, used in Configurable Retry Logic was correct for test environments, and when building the driver manually, but not correct when using the driver as a jar or dependency. This fixes that issue by only removing thetarget/classessuffix if needed.