Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
============================================
+ Coverage 51.50% 51.55% +0.05%
- Complexity 4050 4067 +17
============================================
Files 149 149
Lines 34136 34236 +100
Branches 5700 5718 +18
============================================
+ Hits 17581 17651 +70
- Misses 14076 14103 +27
- Partials 2479 2482 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
machavan
reviewed
Dec 19, 2024
Contributor
|
/azp run public-mssql-jdbc.windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No pipelines are associated with this pull request. |
Contributor
|
/azp run public-mssql-jdbc.linux |
Contributor
|
/azp run CI-MacOS |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
divang
commented
Jan 3, 2025
lilgreenbird
suggested changes
Feb 12, 2025
Contributor
lilgreenbird
left a comment
There was a problem hiding this comment.
need to add tests for datatype conversions. See PR for sql_variant for example
David-Engel
previously approved these changes
Feb 13, 2025
|
Can you update the description with a list of high level areas that have been modified in this PR ? |
saurabh500
reviewed
Feb 14, 2025
David-Engel
previously approved these changes
Feb 14, 2025
machavan
reviewed
Feb 18, 2025
…SON & added testcase to validate it,
352dd3a to
7b23fc8
Compare
David-Engel
reviewed
Jul 9, 2025
Collaborator
David-Engel
left a comment
There was a problem hiding this comment.
Partial review (21/31)
David-Engel
reviewed
Jul 10, 2025
Collaborator
David-Engel
left a comment
There was a problem hiding this comment.
Another partial review 23/31
…ved redundant catch blocks.
…as not visible in VS Code.
David-Engel
reviewed
Jul 16, 2025
…N-to-VECTOR copy, and execute API coverage.
muskan124947
approved these changes
Jul 21, 2025
machavan
approved these changes
Jul 21, 2025
muskan124947
added a commit
that referenced
this pull request
Jul 30, 2025
) * JSON datatype support (#2558) * JSON datatype implementation. Co-authored-by: lilgreenbird <[email protected]> Co-authored-by: Divang Sharma <[email protected]> Co-authored-by: Ananya Garg <[email protected]> Co-authored-by: Muskan Gupta <[email protected]> Co-authored-by: Ananya Garg <[email protected]> * Add new trusted AKV URLs for FR and DE (#2708) * Add new trusted AKV URLs for FR and DE * Update SQLServerColumnEncryptionAzureKeyVaultProvider.java * Enhance code coverage for SQLServerConnectionPoolProxy * Updated test to fix failures --------- Co-authored-by: Divang Sharma <[email protected]> Co-authored-by: lilgreenbird <[email protected]> Co-authored-by: Divang Sharma <[email protected]> Co-authored-by: Ananya Garg <[email protected]> Co-authored-by: Ananya Garg <[email protected]> Co-authored-by: Mahendra Chavan <[email protected]>
Ananya2
added a commit
that referenced
this pull request
Jul 31, 2025
* JSON datatype support (#2558) * JSON datatype implementation. Co-authored-by: lilgreenbird <[email protected]> Co-authored-by: Divang Sharma <[email protected]> Co-authored-by: Ananya Garg <[email protected]> Co-authored-by: Muskan Gupta <[email protected]> Co-authored-by: Ananya Garg <[email protected]> * Add new trusted AKV URLs for FR and DE (#2708) * Add new trusted AKV URLs for FR and DE * Update SQLServerColumnEncryptionAzureKeyVaultProvider.java * Updates for 13.1.1 preview release (#2715) * Updates for 13.1.1 preview release * Fixed PR link * Removed unnecessary space * Enhance test coverage for SQLServerSQLXML file. --------- Co-authored-by: Divang Sharma <[email protected]> Co-authored-by: lilgreenbird <[email protected]> Co-authored-by: Divang Sharma <[email protected]> Co-authored-by: Muskan Gupta <[email protected]> Co-authored-by: Mahendra Chavan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for the JSON datatype in the Microsoft JDBC Driver for SQL Server. With these changes, applications using the driver can now read from and write to SQL Server columns of type JSON, enabling seamless integration with semi-structured data.
Below are some of the example scenarios:
Key Changes
Type System and Metadata
JSONto the type system (enums such asTDSType,SSType,JDBCType, and their categories).Connection and Feature Negotiation
SQLServerConnection, including versioning and server capability detection.Bulk Copy and Data Table Support
SQLServerBulkCopy,SQLServerBulkCSVFileRecord, andSQLServerDataTableto handle JSON columns in bulk operations.Parameter and Value Handling
Test and Build Integration
JSONTestexclusion tags inbuild.gradleandpom.xmlfor targeted testing.Motivation
The addition of JSON datatype support allows Java applications to leverage SQL Server’s native JSON features directly through the JDBC driver. This enhancement addresses modern data requirements by enabling efficient storage, retrieval, and manipulation of semi-structured JSON data within relational workflows.
Testing
For details on all code changes, see the full diff.