Skip to content

Configurable Retry Logic II - Connection Retry#2519

Merged
Jeffery-Wasty merged 8 commits intomainfrom
CLR-conn-part
Nov 20, 2024
Merged

Configurable Retry Logic II - Connection Retry#2519
Jeffery-Wasty merged 8 commits intomainfrom
CLR-conn-part

Conversation

@Jeffery-Wasty
Copy link
Copy Markdown
Contributor

No description provided.

@Jeffery-Wasty Jeffery-Wasty linked an issue Sep 23, 2024 that may be closed by this pull request
@Jeffery-Wasty Jeffery-Wasty added this to the 12.9.1 milestone Sep 23, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 98.91304% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.99%. Comparing base (4ec4d3b) to head (33f0b93).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2519      +/-   ##
============================================
+ Coverage     50.93%   50.99%   +0.05%     
- Complexity     3886     3913      +27     
============================================
  Files           147      147              
  Lines         33368    33447      +79     
  Branches       5592     5606      +14     
============================================
+ Hits          16997    17057      +60     
- Misses        13967    13981      +14     
- Partials       2404     2409       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review November 4, 2024 20:24
@Jeffery-Wasty Jeffery-Wasty modified the milestones: 12.9.1, 12.9.0 Nov 12, 2024
@Jeffery-Wasty Jeffery-Wasty modified the milestones: 12.9.1, 12.9.0 Nov 12, 2024
@Jeffery-Wasty Jeffery-Wasty self-assigned this Nov 12, 2024
@tkyc
Copy link
Copy Markdown
Contributor

tkyc commented Nov 19, 2024

First pass lgtm.

@Jeffery-Wasty
Copy link
Copy Markdown
Contributor Author

@divang @Ananya2 @muskan124947 @machavan you guys can take a look at this too. We're planning to merge this this week for the Monday release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

Reconnection issue with lockTimeout configured

3 participants