Conversation
divang
pushed a commit
that referenced
this pull request
Jan 21, 2025
tkyc
force-pushed
the
exec-cstmt-directly
branch
from
42dc48d to
7ea1bb9
Compare
tkyc
force-pushed
the
exec-cstmt-directly
branch
from
7ea1bb9 to
af52cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update March 28, 2025
This PR involves everything from the initial original/revert PR 2448. Those changes are necessary.
The Pt.2 commit contains the remaining/additional changes. Generally, from my own testing (apart from the last test in the todo) everything was green so far. From my own experience, as I was trying to test and get this working, because the significance of the change encompasses so many places in the driver (eg. from sql string parsing, to tds request building to parsing output params etc...), I recommend another set of eyes to test this.
Todo
The test
testTimestampStringConversionis failing, need to investigate. Hopefully this is the last problem... as everything else seems good.Another set of eyes to test this, if there is opportunity.