Revert Execute Stored Procedure directly feature#2488
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2488 +/- ##
============================================
- Coverage 50.78% 50.58% -0.21%
+ Complexity 3888 3817 -71
============================================
Files 145 145
Lines 33481 33137 -344
Branches 5690 5560 -130
============================================
- Hits 17004 16762 -242
+ Misses 14030 13974 -56
+ Partials 2447 2401 -46 ☔ View full report in Codecov by Sentry. |
Jeffery-Wasty
requested review from
Jeffery-Wasty,
barryw-mssql and
lilgreenbird
lilgreenbird
changed the title
lilgreenbird
previously approved these changes
Aug 21, 2024
Jeffery-Wasty
previously approved these changes
Aug 21, 2024
Jeffery-Wasty
approved these changes
Aug 21, 2024
lilgreenbird
approved these changes
Aug 21, 2024
tkyc
added a commit
that referenced
this pull request
Aug 21, 2024
* Revert "Execute Stored Procedures Directly (#2154)" This reverts commit 11680a6. * Revert "Execute cstmt directly - Additional testing and changes (#2284)" This reverts commit 92cfe0d. * Revert "Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)" This reverts commit ba88da8. * Additional revert of missed lines * Added no-op for getters/setters * RequestBoundaryMethods no-op test fix
tkyc
added a commit
that referenced
this pull request
Aug 22, 2024
* Revert "Execute Stored Procedures Directly (#2154)" This reverts commit 11680a6. * Revert "Execute cstmt directly - Additional testing and changes (#2284)" This reverts commit 92cfe0d. * Revert "Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)" This reverts commit ba88da8. * Additional revert of missed lines * Added no-op for getters/setters * RequestBoundaryMethods no-op test fix
tkyc
added a commit
that referenced
this pull request
Aug 23, 2024
* Revert "Execute Stored Procedures Directly (#2154)" This reverts commit 11680a6. * Revert "Execute cstmt directly - Additional testing and changes (#2284)" This reverts commit 92cfe0d. * Revert "Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)" This reverts commit ba88da8. * Additional revert of missed lines * Added no-op for getters/setters * RequestBoundaryMethods no-op test fix
tkyc
added a commit
that referenced
this pull request
Aug 28, 2024
* Revert "Execute Stored Procedures Directly (#2154)" This reverts commit 11680a6. * Revert "Execute cstmt directly - Additional testing and changes (#2284)" This reverts commit 92cfe0d. * Revert "Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)" This reverts commit ba88da8. * Additional revert of missed lines * Added no-op for getters/setters * RequestBoundaryMethods no-op test fix
|
will this ever be brought back at some point? the way the old 'wrapper' works makes it impossible to return (n)varchar(max) from a stored procedure, which is very limiting... - thanks. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of the following:
Fixed regression with specifying arg names in call syntax (#2480)
0e97689
Fixed parentheses parsing for stored procedures and functions names (#2467)
8f53c02
Fixed CallableStatement default value regression (#2452)
9307051
Fixed timestamp string conversion error for cstmt (#2449)
9754078
Execute stored procedures directly for RPC calls (#2410)
df5bfa6
Fix calling procedures with output parameters by their four-part syntax (#2349)
aa46637
Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)
ba88da8
Execute cstmt directly - Additional testing and changes (#2284)
92cfe0d
Execute Stored Procedures Directly (#2154)
11680a6