Skip to content

[Backport] Fixed timestamp string conversion error for cstmt (2449)#2455

Merged
Jeffery-Wasty merged 2 commits intorelease/12.6from
12.6.3-timestamp
Jun 20, 2024
Merged

[Backport] Fixed timestamp string conversion error for cstmt (2449)#2455
Jeffery-Wasty merged 2 commits intorelease/12.6from
12.6.3-timestamp

Conversation

@tkyc
Copy link
Copy Markdown
Contributor

@tkyc tkyc commented Jun 19, 2024

Backport #2449

* Fixed timestamp string conversion error for cstmt

* Code review comments p1

* Fixed sproc used in test
@Jeffery-Wasty Jeffery-Wasty changed the title [Backport] Fixed timestamp string conversion error for cstmt [Backport] Fixed timestamp string conversion error for cstmt (2449) Jun 19, 2024
@Jeffery-Wasty Jeffery-Wasty added this to the 12.6.3 milestone Jun 19, 2024
Jeffery-Wasty
Jeffery-Wasty previously approved these changes Jun 19, 2024
barryw-mssql
barryw-mssql previously approved these changes Jun 20, 2024
@Jeffery-Wasty Jeffery-Wasty dismissed stale reviews from barryw-mssql and themself via 42c463c June 20, 2024 18:02
@Jeffery-Wasty Jeffery-Wasty merged commit ee044a8 into release/12.6 Jun 20, 2024
@Jeffery-Wasty Jeffery-Wasty deleted the 12.6.3-timestamp branch June 20, 2024 18:03
dongjoon-hyun pushed a commit to apache/spark that referenced this pull request Jul 22, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade `mssql-jdbc` from `12.6.2.jre11` to `12.6.3.jre11`

### Why are the changes needed?
https://github.com/microsoft/mssql-jdbc/releases/tag/v12.6.3
Hotfix & Stable Release:
- Fixed issue where TokenCredential class was required to be imported microsoft/mssql-jdbc#2453
- Fixed timestamp string conversion regression microsoft/mssql-jdbc#2455
- Fixed SQLServerCallableStatement default value regression microsoft/mssql-jdbc#2456

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #47075 from panbingkun/SPARK-48703.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

4 participants