Caching SQLServerBulkCopy object for batch insert#2435
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2435 +/- ##
============================================
+ Coverage 50.13% 50.77% +0.64%
- Complexity 3842 3880 +38
============================================
Files 145 145
Lines 33409 33421 +12
Branches 5667 5676 +9
============================================
+ Hits 16750 16970 +220
+ Misses 14258 14006 -252
- Partials 2401 2445 +44 ☔ View full report in Codecov by Sentry. |
Jeffery-Wasty
previously approved these changes
Jun 3, 2024
barryw-mssql
previously approved these changes
Jun 4, 2024
lilgreenbird
reviewed
Jun 5, 2024
Jeffery-Wasty
approved these changes
Jun 11, 2024
lilgreenbird
approved these changes
Jun 13, 2024
barryw-mssql
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If bulkcopy is used for batch insert, and if multiple
executeBatch()calls are made against the same prepared statement, then multiple SQLServerBulkCopy objects are instantiated which will cause repeated calls toselect * sys.columns.... This PR caches the SQLServerBulkCopy object.