Modifications to eliminate stack overflow when parsing specific CSV f…#2434
Merged
barryw-mssql merged 1 commit intomainfrom May 28, 2024
Merged
Modifications to eliminate stack overflow when parsing specific CSV f…#2434barryw-mssql merged 1 commit intomainfrom
barryw-mssql merged 1 commit intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
============================================
- Coverage 50.19% 50.12% -0.07%
- Complexity 3851 3852 +1
============================================
Files 145 145
Lines 33394 33409 +15
Branches 5662 5667 +5
============================================
- Hits 16761 16747 -14
- Misses 14258 14280 +22
- Partials 2375 2382 +7 ☔ View full report in Codecov by Sentry. |
David-Engel
approved these changes
May 28, 2024
tkyc
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove recursion when parsing CSV files resulting in a stack overflow. Add new test and CSV data file
#2400