Fix SqlAuthenticationToken constructor accepting unix epoch#2425
Merged
Jeffery-Wasty merged 3 commits intomicrosoft:mainfrom May 22, 2024
Merged
Fix SqlAuthenticationToken constructor accepting unix epoch#2425Jeffery-Wasty merged 3 commits intomicrosoft:mainfrom
Jeffery-Wasty merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@barryw-mssql @tkyc Could you help to review this fix? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
============================================
+ Coverage 50.08% 50.10% +0.01%
- Complexity 3832 3838 +6
============================================
Files 145 145
Lines 33396 33394 -2
Branches 5662 5662
============================================
+ Hits 16728 16732 +4
+ Misses 14269 14265 -4
+ Partials 2399 2397 -2 ☔ View full report in Codecov by Sentry. |
barryw-mssql
previously approved these changes
May 22, 2024
Contributor
|
@konjac Thanks for the PR, we'll take a look at it and get back to you with our thoughts. |
tkyc
previously approved these changes
May 22, 2024
Jeffery-Wasty
suggested changes
May 22, 2024
Contributor
Jeffery-Wasty
left a comment
Jeffery-Wasty
left a comment
There was a problem hiding this comment.
Hold off on merging for a bit
tkyc
previously approved these changes
May 22, 2024
Jeffery-Wasty
approved these changes
May 22, 2024
tkyc
approved these changes
May 22, 2024
barryw-mssql
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address #2424