Make enum SQLServerSortOrder become public#2405
Merged
Jeffery-Wasty merged 1 commit intomicrosoft:mainfrom May 10, 2024
Merged
Conversation
Issue microsoft#2404 Make this enum to be public, so that people can create "SQLServerMetaData" like below: new SQLServerMetaData("row_id", java.sql.Types.INTEGER, 0, 0, true, false, SQLServerSortOrder.Unspecified, -1)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2405 +/- ##
============================================
+ Coverage 49.88% 50.21% +0.33%
- Complexity 3827 3841 +14
============================================
Files 145 145
Lines 33360 33360
Branches 5654 5654
============================================
+ Hits 16642 16753 +111
+ Misses 14349 14211 -138
- Partials 2369 2396 +27 ☔ View full report in Codecov by Sentry. |
tkyc
approved these changes
May 7, 2024
Contributor
|
FYI for the team. This is used in |
Jeffery-Wasty
approved these changes
May 7, 2024
barryw-mssql
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2404
Make this enum to be public, so that people can create "SQLServerMetaData" like below:
new SQLServerMetaData("row_id", java.sql.Types.INTEGER, 0, 0, true, false, SQLServerSortOrder.Unspecified, -1)