Skip to content

Check that money/small money are within correct range for bulkcopy#2379

Merged
Jeffery-Wasty merged 5 commits intomainfrom
moneySmallMoneyFix
Apr 4, 2024
Merged

Check that money/small money are within correct range for bulkcopy#2379
Jeffery-Wasty merged 5 commits intomainfrom
moneySmallMoneyFix

Conversation

@Jeffery-Wasty
Copy link
Copy Markdown
Contributor

Fixes #2309

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.23%. Comparing base (78bdefd) to head (7ee5be8).

❗ Current head 7ee5be8 differs from pull request most recent head 13fb1df. Consider uploading reports for the commit 13fb1df to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2379      +/-   ##
============================================
+ Coverage     50.21%   50.23%   +0.02%     
- Complexity     3841     3848       +7     
============================================
  Files           145      145              
  Lines         33358    33360       +2     
  Branches       5654     5654              
============================================
+ Hits          16750    16759       +9     
+ Misses        14221    14211      -10     
- Partials       2387     2390       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilgreenbird lilgreenbird added this to the 12.7.0 milestone Apr 3, 2024
@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review April 4, 2024 17:35
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated
barryw-mssql
barryw-mssql previously approved these changes Apr 4, 2024
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java Outdated
Copy link
Copy Markdown
Contributor

@lilgreenbird lilgreenbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run formatter

tkyc
tkyc previously approved these changes Apr 4, 2024
@Jeffery-Wasty Jeffery-Wasty merged commit 5b3f32e into main Apr 4, 2024
@Jeffery-Wasty Jeffery-Wasty deleted the moneySmallMoneyFix branch April 4, 2024 21:35
Jeffery-Wasty added a commit that referenced this pull request Apr 10, 2024
* Changes as per prior code review

* setupMoneyTests can be added to beforeAll, it should be ran each time

* Passed in wrong values for tests
tkyc added a commit that referenced this pull request May 27, 2024
tkyc added a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

When I try to insert the value beyond the range, it inserting wrong values with small money/money.

4 participants