Add support for TDSType.GUID (fix) (#1582)#2370
Merged
lilgreenbird merged 4 commits intomicrosoft:mainfrom Apr 2, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2370 +/- ##
============================================
- Coverage 50.10% 50.07% -0.03%
- Complexity 3813 3817 +4
============================================
Files 145 145
Lines 33286 33319 +33
Branches 5639 5644 +5
============================================
+ Hits 16677 16684 +7
- Misses 14221 14254 +33
+ Partials 2388 2381 -7 ☔ View full report in Codecov by Sentry. |
lilgreenbird
reviewed
Apr 1, 2024
lilgreenbird
reviewed
Apr 1, 2024
lilgreenbird
previously approved these changes
Apr 1, 2024
lilgreenbird
reviewed
Apr 1, 2024
lilgreenbird
reviewed
Apr 1, 2024
lilgreenbird
approved these changes
Apr 1, 2024
tkyc
approved these changes
Apr 1, 2024
Contributor
Author
|
@lilgreenbird Thanks for the correction. I wasn't aware of this Azure SQL Data Warehouse limitation. |
Jeffery-Wasty
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the merged and reverted PR #2324.
The original PR intends to provide support for sending UUID parameters as
TDSType.GUID (0x24)on the wire and (hopefully) implements feature request #1582.It currently requires the Java parameter be given to the driver as
StringwithJDBCType.GUID, i.e. :