Skip to content

Escape schema for getProcedures and getProcedureColumns in SQLServerDatabaseMetaData#2369

Merged
Jeffery-Wasty merged 4 commits intomainfrom
escape-schema-fix
Apr 2, 2024
Merged

Escape schema for getProcedures and getProcedureColumns in SQLServerDatabaseMetaData#2369
Jeffery-Wasty merged 4 commits intomainfrom
escape-schema-fix

Conversation

@tkyc
Copy link
Copy Markdown
Contributor

@tkyc tkyc commented Mar 26, 2024

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 85.96491% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 50.15%. Comparing base (7e0dcb3) to head (adba1fb).
Report is 6 commits behind head on main.

❗ Current head adba1fb differs from pull request most recent head 0666524. Consider uploading reports for the commit 0666524 to get more accurate results

Files Patch % Lines
...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java 80.00% 3 Missing and 1 partial ⚠️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2369      +/-   ##
============================================
+ Coverage     50.09%   50.15%   +0.05%     
- Complexity     3814     3825      +11     
============================================
  Files           145      145              
  Lines         33291    33340      +49     
  Branches       5639     5651      +12     
============================================
+ Hits          16677    16721      +44     
- Misses        14226    14230       +4     
- Partials       2388     2389       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

barryw-mssql
barryw-mssql previously approved these changes Mar 27, 2024
@lilgreenbird lilgreenbird added this to the 12.7.0 milestone Mar 27, 2024
@lilgreenbird lilgreenbird changed the title Escape schema fix Escape schema for getProcedures and getProcedureColumns in SQLServerDatabaseMetaData Mar 27, 2024
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/TestUtils.java Outdated
Jeffery-Wasty
Jeffery-Wasty previously approved these changes Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

Connection.getMetaData().getProcedures does not handle schema as a pattern

4 participants