Skip to content

Clear prepared statement cache when resetting statement pool connection#2361

Merged
lilgreenbird merged 1 commit intomainfrom
poolingfix
Apr 2, 2024
Merged

Clear prepared statement cache when resetting statement pool connection#2361
lilgreenbird merged 1 commit intomainfrom
poolingfix

Conversation

@lilgreenbird
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.16%. Comparing base (9a8849b) to head (762fb2f).

❗ Current head 762fb2f differs from pull request most recent head e42426a. Consider uploading reports for the commit e42426a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2361      +/-   ##
============================================
+ Coverage     50.03%   50.16%   +0.13%     
- Complexity     3785     3806      +21     
============================================
  Files           143      143              
  Lines         33204    33206       +2     
  Branches       5629     5630       +1     
============================================
+ Hits          16613    16658      +45     
+ Misses        14207    14173      -34     
+ Partials       2384     2375       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilgreenbird lilgreenbird marked this pull request as ready for review March 22, 2024 20:47
@lilgreenbird lilgreenbird merged commit 7c78c48 into main Apr 2, 2024
@lilgreenbird lilgreenbird deleted the poolingfix branch April 3, 2024 00:45
Jeffery-Wasty added a commit that referenced this pull request May 17, 2024
tkyc pushed a commit that referenced this pull request May 22, 2024
dongjoon-hyun pushed a commit to apache/spark that referenced this pull request Aug 3, 2024
…QLServer docker image tag to `2022-CU14-ubuntu-22.04`

### What changes were proposed in this pull request?

This PR aims to upgrade `mssql-jdbc` to 12.8.0.jre11 and MySQLServer docker image to `mcr.microsoft.com/mssql/server:2022-CU14-ubuntu-22.04`.

### Why are the changes needed?

This is the latest stable version of `mssql-jdbc`,  related release notes:

https://github.com/microsoft/mssql-jdbc/releases/tag/v12.7.0
https://github.com/microsoft/mssql-jdbc/releases/tag/v12.7.1
https://github.com/microsoft/mssql-jdbc/releases/tag/v12.8.0

Some fixed issues:

- Fix to ensure metadata returned follows JDBC data type specs microsoft/mssql-jdbc#2326
- Added token cache map to fix use of unintended auth token for subsequent connections microsoft/mssql-jdbc#2341
- Clear prepared statement handle before reconnect microsoft/mssql-jdbc#2364
- Reset socketTimeout to original value after a successful connection open microsoft/mssql-jdbc#2355
- Clear prepared statement cache when resetting statement pool connection microsoft/mssql-jdbc#2361
- Fixed ClassLoader leak of ActivityCorrelator ThreadLocal microsoft/mssql-jdbc#2366

### Does this PR introduce _any_ user-facing change?

No.
### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #47569 from wayneguow/ms_12_8.

Authored-by: Wei Guo <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

Erroneously inserted rows with statement pooling enabled and when a Connection gets re-used from the ConnectionPool

4 participants