Skip to content

Fixed missing this -> wrong semantics#232

Merged
AfsanehR-zz merged 2 commits intomicrosoft:devfrom
pierresouchay:bugfixes
Apr 17, 2017
Merged

Fixed missing this -> wrong semantics#232
AfsanehR-zz merged 2 commits intomicrosoft:devfrom
pierresouchay:bugfixes

Conversation

@pierresouchay
Copy link
Copy Markdown
Contributor

@pierresouchay pierresouchay commented Apr 3, 2017

Fixed simple missing this that cause not assigned type member

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 3, 2017 •
edited
Loading

Codecov Report

Merging #232 into dev will increase coverage by 0.33%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #232      +/-   ##
============================================
+ Coverage     33.35%   33.68%   +0.33%     
- Complexity     1486     1511      +25     
============================================
  Files            97       97              
  Lines         23569    23571       +2     
  Branches       3909     3910       +1     
============================================
+ Hits           7862     7941      +79     
+ Misses        14141    14063      -78     
- Partials       1566     1567       +1
Flag Coverage Δ Complexity Δ
#JDBC41 33.48% <0%> (+0.19%) 1495 <0> (+12) ⬆️
#JDBC42 33.59% <0%> (+0.34%) 1507 <0> (+28) ⬆️
Impacted Files Coverage Δ Complexity Δ
...va/com/microsoft/sqlserver/jdbc/SQLServerBlob.java 26.31% <0%> (-0.28%) 13 <0> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 44.69% <0%> (-0.22%) 181% <0%> (-2%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 29.43% <0%> (+0.34%) 84% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 37.33% <0%> (+0.38%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 34.58% <0%> (+0.61%) 0% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 69.86% <0%> (+0.84%) 5% <0%> (+2%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 30.47% <0%> (+0.85%) 36% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 24.86% <0%> (+1.22%) 179% <0%> (+10%) ⬆️
...main/java/com/microsoft/sqlserver/jdbc/Column.java 33.12% <0%> (+1.25%) 32% <0%> (+2%) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 41.91% <0%> (+1.47%) 10% <0%> (+1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d22ac...e178fca. Read the comment docs.

@pierresouchay
Fixed possible NullPointerException.
e178fca 
This exception may occur at least in the following cases:

* Race condition between free() and trying to open stream
* Serialization (since it does not seems well implemented, I doubt activeStreams
  can be serialized properly)

I am not sure at all serialization is working well.

About the race condition, I am almost sure all of this is not thread-safe, but
I am too lazy to read JDBC specification regarding blobs.
@v-nisidh v-nisidh added this to the 6.1.7 milestone Apr 4, 2017
@v-nisidh v-nisidh requested a review from AfsanehR-zz April 10, 2017 21:26
@AfsanehR-zz AfsanehR-zz merged commit 1bc07b2 into microsoft:dev Apr 17, 2017
@AfsanehR-zz
Copy link
Copy Markdown
Contributor

AfsanehR-zz commented Apr 17, 2017

Thank you @pierresouchay for the pull request!

@pierresouchay pierresouchay deleted the bugfixes branch April 18, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AfsanehR-zz AfsanehR-zz Awaiting requested review from AfsanehR-zz

1 more reviewer

@v-nisidh v-nisidh v-nisidh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.1.7

Development

Successfully merging this pull request may close these issues.

5 participants

@pierresouchay @codecov-io @AfsanehR-zz @v-nisidh @lilgreenbird