Fix to allow connection retries to be disabled by setting connectRetryCount to 0#2293
Merged
lilgreenbird merged 3 commits intomainfrom Feb 29, 2024
Merged
Fix to allow connection retries to be disabled by setting connectRetryCount to 0#2293lilgreenbird merged 3 commits intomainfrom
lilgreenbird merged 3 commits intomainfrom
Conversation
Jeffery-Wasty
approved these changes
Jan 16, 2024
Contributor
|
I did a quick test and I see that it's retrying twice. Repro app EDIT: Nevermind, it should be twice when TNIR=true. |
Jeffery-Wasty
previously approved these changes
Jan 18, 2024
tkyc
previously approved these changes
Jan 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
=============================================
- Coverage 73.60% 50.04% -23.56%
+ Complexity 6082 3786 -2296
=============================================
Files 142 143 +1
Lines 33123 33128 +5
Branches 5623 5628 +5
=============================================
- Hits 24380 16579 -7801
- Misses 6234 14171 +7937
+ Partials 2509 2378 -131 ☔ View full report in Codecov by Sentry. |
tkyc
reviewed
Feb 28, 2024
Jeffery-Wasty
approved these changes
Feb 28, 2024
tkyc
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.