Skip to content

Fix for bigDecimal values between 0 and 1 having too high of a precision#2116

Merged
Jeffery-Wasty merged 19 commits intomainfrom
bigDecimalLessThan1Fix
May 4, 2023
Merged

Fix for bigDecimal values between 0 and 1 having too high of a precision#2116
Jeffery-Wasty merged 19 commits intomainfrom
bigDecimalLessThan1Fix

Conversation

@Jeffery-Wasty
Copy link
Copy Markdown
Contributor

@Jeffery-Wasty Jeffery-Wasty commented May 1, 2023

Changes how precision and scaling are computed for bigDecimal values to account for a big where precision is 1 too high for numbers between 0 and 1.

@Jeffery-Wasty Jeffery-Wasty requested review from lilgreenbird and tkyc May 2, 2023 17:05
@Jeffery-Wasty Jeffery-Wasty changed the title Fix for numbers between 0 and 1. Fix for bigDecimal values between 0 and 1 having too high of a precision May 2, 2023
@Jeffery-Wasty Jeffery-Wasty linked an issue May 2, 2023 that may be closed by this pull request
@Jeffery-Wasty Jeffery-Wasty added the Under Review Used for pull requests under review label May 2, 2023
@Jeffery-Wasty Jeffery-Wasty added this to the 12.3.0 milestone May 2, 2023
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java Outdated
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/Parameter.java Outdated
@Jeffery-Wasty Jeffery-Wasty force-pushed the bigDecimalLessThan1Fix branch from f8aa81e to f381a1a Compare May 4, 2023 16:32
@Jeffery-Wasty Jeffery-Wasty merged commit e373323 into main May 4, 2023
@Jeffery-Wasty Jeffery-Wasty deleted the bigDecimalLessThan1Fix branch May 4, 2023 19:59
@Jeffery-Wasty Jeffery-Wasty removed the Under Review Used for pull requests under review label May 4, 2023
tkyc pushed a commit that referenced this pull request Jul 26, 2023
…es between 0 and 1 having too high of a precision) (#2176)

* Revert big decimal changes

* Delete TestClass.java

* Delete RetryLogicProvider.java

* Update Parameter.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong precision for BigDecimal < 0 (since #2051)

2 participants