Conversation
| e.errorCode = XAException.XAER_RMFAIL; | ||
| throw e; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
this makes me wonder about other errors that we should not RMERR on. I see similar issues in Oracle as well. I'm wondering if we should check severity?
Collaborator
There was a problem hiding this comment.
As discussed offline, we expect the statement we call to return an XA status (including any XA errors). Any other error the driver receives, like a server-level error, it would be difficult to discern/translate those into the correct RMERR/RMFAIL status. So going with the conservative change here and only changing the specific behavior we believe should be changed from RMERR to RMFAIL. Other cases will remain the same (RMERR).
Jeffery-Wasty
approved these changes
Mar 1, 2023
lilgreenbird
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1432