Skip to content

Fixed incorrect updateCount#2013

Merged
tkyc merged 4 commits intomainfrom
updatecount-fix-1961
Dec 28, 2022
Merged

Fixed incorrect updateCount#2013
tkyc merged 4 commits intomainfrom
updatecount-fix-1961

Conversation

@tkyc
Copy link
Copy Markdown
Contributor

@tkyc tkyc commented Dec 23, 2022

Fix for #1961. The incorrect update count can happen in both true/false cases for enablePrepareOnFirstPreparedStatementCall and for both prepexec/prepare.

Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java Outdated
@tkyc tkyc requested a review from lilgreenbird December 23, 2022 21:19
Jeffery-Wasty
Jeffery-Wasty previously approved these changes Dec 23, 2022
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java Outdated
@Jeffery-Wasty Jeffery-Wasty self-requested a review December 28, 2022 18:10
@tkyc tkyc merged commit ef3ff46 into main Dec 28, 2022
@tkyc tkyc deleted the updatecount-fix-1961 branch December 28, 2022 21:42
tkyc added a commit that referenced this pull request Dec 28, 2022
* Fixed incorrect updateCount

* Formatting changes

* Additional testing and changes

* Removed debug print line
tkyc added a commit that referenced this pull request Dec 28, 2022
* Fixed incorrect updateCount

* Formatting changes

* Additional testing and changes

* Removed debug print line
tkyc added a commit that referenced this pull request Dec 29, 2022
* Fixed incorrect updateCount

* Formatting changes

* Additional testing and changes

* Removed debug print line
tkyc added a commit that referenced this pull request Dec 29, 2022
* Fixed incorrect updateCount

* Formatting changes

* Additional testing and changes

* Removed debug print line
tkyc added a commit that referenced this pull request Jan 3, 2023
* Fixed incorrect updateCount (#2013)

* Fixed incorrect updateCount

* Formatting changes

* Additional testing and changes

* Removed debug print line

* Added null check
@lilgreenbird lilgreenbird added this to the 12.2.0 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants