Batched CallableStatement timeout handling#1960
Closed
mmimica wants to merge 5 commits intomicrosoft:mainfrom
Closed
Batched CallableStatement timeout handling#1960mmimica wants to merge 5 commits intomicrosoft:mainfrom
mmimica wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Release | Merge dev to master for 9.1.1-preview release
Merge dev to master for 9.2.0 release (microsoft#1506)
# Conflicts: # CHANGELOG.md # README.md # azure-pipelines.yml # build.gradle # mssql-jdbc_auth_LICENSE # pom.xml # src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java # src/main/java/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java # src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java # src/main/java/com/microsoft/sqlserver/jdbc/SQLServerMSAL4JUtils.java # src/samples/adaptive/pom.xml # src/samples/alwaysencrypted/pom.xml # src/samples/azureactivedirectoryauthentication/pom.xml # src/samples/connections/pom.xml # src/samples/constrained/pom.xml # src/samples/dataclassification/pom.xml # src/samples/datatypes/pom.xml # src/samples/resultsets/pom.xml # src/samples/sparse/pom.xml # src/test/java/com/microsoft/sqlserver/jdbc/TestResource.java # src/test/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetaDataTest.java # src/test/java/com/microsoft/sqlserver/jdbc/fedauth/ErrorMessageTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driver version
11.2.1, main
Table schema
See com.microsoft.sqlserver.jdbc.unit.statement.BatchExecutionTest#testBatchedSpCallTimeout in the PR.
Problem description
With
enablePrepareOnFirstPreparedStatementCall=true.When timeout happens, the update count in the
BatchUpdateExceptionis incorrect and doesn't reflect what actually happened.Expected behavior
In the test, 5 statements are executed in a batch. The 4th one statement times out. The first three succeed, the last two fail.
updateCountshould reflect that.Actual behavior
updateCounts [1, -3, 1, -3, -3] - indicating that the second call failed, while it didn't. Either [1, 1, -3, -3, -3] or [1, 1, -1, -3, -3] would be acceptable.
Any other details that can be helpful
Only with
enablePrepareOnFirstPreparedStatementCall=true.