BigDecimal Precision/Scale Fix#1912
Merged
Jeffery-Wasty merged 10 commits intomainfrom Sep 21, 2022
Merged
Conversation
This was
linked to
issues
Sep 3, 2022
…) in Paramater.java.
…n be rolled back if wanted.)
Contributor
Author
|
I've applied the formatting change with |
tkyc
approved these changes
Sep 20, 2022
lilgreenbird
approved these changes
Sep 21, 2022
lilgreenbird
added a commit
that referenced
this pull request
Sep 26, 2022
This reverts commit 05ef7c0.
lilgreenbird
added a commit
that referenced
this pull request
Sep 26, 2022
This was referenced Sep 26, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For operations with
BigDecimal, precision and scale of 38 and 1 respectively (decimal(38,1)) are used, as opposed to the actual values for the object. This leads to loss of accuracy in transactions involvingBigDecimal. This changes theparam.typeDefinitionto match the precision from theBigDecimalobject. Four tests to confirm the fix for subtraction, addition, multiplication, and division operations are also present. This fixes issues 1489 and 942.Parameter.java
BigDecimalobject, whose value is notnull, and whose precision is larger than the present scale (default1), assignsparam.typeDefinitiona precision based on the object, as opposed to the maximum value (38) previously used.StatementTest.java