Added check for DONE_ERROR status token and throw appropriate exception#1857
Merged
lilgreenbird merged 13 commits intomicrosoft:mainfrom Jul 20, 2022
Merged
Added check for DONE_ERROR status token and throw appropriate exception#1857lilgreenbird merged 13 commits intomicrosoft:mainfrom
lilgreenbird merged 13 commits intomicrosoft:mainfrom
Conversation
lilgreenbird
force-pushed
the
killsession
branch
from
ad8a01b to
8824de1
Compare
tkyc
reviewed
Jun 29, 2022
lilgreenbird
changed the title
lilgreenbird
changed the title
David-Engel
reviewed
Jun 30, 2022
Jeffery-Wasty
previously approved these changes
Jul 12, 2022
tkyc
previously approved these changes
Jul 12, 2022
David-Engel
approved these changes
Jul 19, 2022
Collaborator
David-Engel
left a comment
David-Engel
left a comment
There was a problem hiding this comment.
Assuming the test stability is worked out, I'm good with the changes, from a funtional perspective.
tkyc
approved these changes
Jul 19, 2022
Jeffery-Wasty
approved these changes
Jul 20, 2022
VeryVerySpicy
approved these changes
Jul 20, 2022
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1846 and #1505 where a DONE_ERROR status from the server resulting from a killed session was ignored by the driver.