Remove Commands from TimeoutPoller when they have Completed#1782
Closed
johnny-egeland wants to merge 1 commit intomicrosoft:mainfrom
Closed
Remove Commands from TimeoutPoller when they have Completed#1782johnny-egeland wants to merge 1 commit intomicrosoft:mainfrom
johnny-egeland wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
|
closing as this is obsoleted by #1794 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TimeoutPoller previously did not release completed commands, and retained the instance in the command array until the entire timeout period has elapsed. Then it would unnecessarily call interrupt() on the command, before removing it from the TimeoutPoller.
This had the side effect that object being added to the TimeoutPoller would not be Garbage Collected until after the entire timeout period. If the query timeout was sufficiently long, it could potentially result in out-of-memory exceptions when the frequency of queries is high. Managing this by reducing the query timeout becomes an unnecessary "tuning" problem, where you choose between memory usage and the possibility of cancelling fully working but long lasting queries.
This commit fixes this issue by removing completed commands from the TimeoutPoller regardless of being timed out or not. This insures the command instances can be garbage collected. The issue has been reported here:
#1781