Added check for MSAL library when attempting ActiveDirectoryServicePrincipal authentication#1759
Merged
lilgreenbird merged 1 commit intomicrosoft:mainfrom Mar 3, 2022
Merged
Conversation
Contributor
|
Thank you for the contribution @caseyhall. We'll take a look and get back to you. |
lilgreenbird
approved these changes
Mar 3, 2022
tkyc
approved these changes
Mar 3, 2022
Jeffery-Wasty
approved these changes
Mar 3, 2022
VeryVerySpicy
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor change. This check exists for other AD auth cases, but will just throw java.lang.ClassNotFoundException if ActiveDirectoryServicePrincipal is used and MSAL libraries are not in the classpath. In another project, I had spent some time trying to determine the issue, only to notice this missing check would have been helpful.
This just adds the check used in other AD auth cases to the ActiveDirectoryServicePrincipal case.
now returns:
Thanks