Added Azure Active Directory tests for Azure Data Explorer using user/password/applicationName AND removed deprecated tags to fix build warnings#1755
Merged
Jeffery-Wasty merged 3 commits intomainfrom Feb 22, 2022
Conversation
|
|
lilgreenbird
changed the title
lilgreenbird
changed the title
Jeffery-Wasty
changed the title
…SECRET, to remove build warnings.
Jeffery-Wasty
changed the title
VeryVerySpicy
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After migration from ADAL to MSAL4J, clients were unable to connect to certain endpoints (e.g. Azure Data Explorer). This issue was resolved by the Azure Data Explorer / Kusto team, by allowing another property to be passed into the connection string, changing the authority used when connecting with MSAL4J, and resolving the error.
An Azure Active Directory test was implemented to confirm the workaround does work for JDBC driver, and for authentication using Azure Active Directory username and password.
Original issue and fix: AzureAD/microsoft-authentication-library-for-java#382
On build, warnings were given regarding deprecated properties. There wasn't a need for these properties to be marked as deprecated, and as such, the tags have been removed, removing the warnings.