Simplify traceID creation in DataSource and PooledConnection.#1747
Merged
lilgreenbird merged 1 commit intomicrosoft:mainfrom Feb 11, 2022
Merged
Simplify traceID creation in DataSource and PooledConnection.#1747lilgreenbird merged 1 commit intomicrosoft:mainfrom
lilgreenbird merged 1 commit intomicrosoft:mainfrom
Conversation
This will also make sure the traceID is set before used in toString().
|
|
Contributor
Author
|
Hard to see what the reason for those build failures is, but it looks not related. It is maybe a good idea to remove flaky timeout tests from the pull request review builds. Can this be retried? |
Contributor
|
hi @ecki thank you for your contribution, the team will take a look |
VeryVerySpicy
approved these changes
Feb 3, 2022
tkyc
approved these changes
Feb 3, 2022
lilgreenbird
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will also make sure the traceID is set before used in toString().
The loggername handling seems to be a bit divergent- in some cases a literal package is used in others not. I am not sure if this is intentional, so I left it alone.
Sorry for the removal of trailing whitespaces, but I figured it it generally helpful. If you want me to isolate the changes, please let me know.
Signed-off-by: Bernd Eckenfels [email protected]